Skip to content
This repository has been archived by the owner on Jan 30, 2020. It is now read-only.

systemd,agent: unload unit only when TriggerStop() runs successfully #1646

Merged
merged 3 commits into from
Jul 22, 2016

Commits on Jul 20, 2016

  1. systemd: make systemdUnitManager.Trigger{Start,Stop}() return errors

    Make systemdUnitManager.Trigger{Start,Stop}() return errors, if their
    underlying library functions from go-systemd return errors.
    FakeUnitManager must be also updated according to these changes.
    Dongsu Park committed Jul 20, 2016
    Configuration menu
    Copy the full SHA
    1557822 View commit details
    Browse the repository at this point in the history
  2. agent: unload unit only when TriggerStop() runs successfully

    In Agent.unloadUnit(), if systemdUnitManager.TriggerStop() returns
    any error, do not unload systemd units. Otherwise the unit could get
    into a state where the unit cannot be stopped via fleet, because the
    unit file was already removed.
    
    Fixes coreos#1216
    Dongsu Park committed Jul 20, 2016
    Configuration menu
    Copy the full SHA
    3b811ba View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2016

  1. functional: check error values from TriggerStart and TriggerStop

    In TestSystemdUnitFlow(), if Trigger{Start,Stop} returns an error,
    then stop immediately.
    Dongsu Park committed Jul 21, 2016
    Configuration menu
    Copy the full SHA
    05b0da9 View commit details
    Browse the repository at this point in the history