-
Notifications
You must be signed in to change notification settings - Fork 302
fleetd: process dependencies in [Install] section #1655
Conversation
e018628
to
41fe88f
Compare
Hmm, interesting. |
41fe88f
to
ff5ed5f
Compare
22b0396
to
5c5e1d0
Compare
@dongsupark last one doesn't relate to install stuff. |
@kayrus Right. I was just taking a try-and-error approach. But none of the reverted patches was a culprit. |
3b16720
to
a1aa889
Compare
150d30c
to
4002bf5
Compare
3b60e93
to
875d938
Compare
To sum up, this PR works fine on CoreOS alpha v1151.0.0 (with systemd v231), while it still fails with CoreOS beta(1122) & stable(1068) (with systemd v229). So the issue of failing functional test was clearly not a fleet issue. |
6bf29a9
to
2650ed4
Compare
CoreOS stable was updated to 1185.3.0 with systemd v231. So finally this PR can be merged. However it's still pending due to other test failures. It's blocked by #1700. |
2650ed4
to
bb1fc6b
Compare
bb1fc6b
to
4a94037
Compare
All right. As the blocker #1700 was merged, I'll also merge this PR. |
Bit late to this. Code LGTM, but @dongsupark what do you think about making this configurable, since it can seem a bit unintuitive? |
@jonboulle I agree that it's unintuitive, but I'm not sure about how to make it configurable for users. AFAICS users anyway need to write own unit files for dependencies, with either Wants or WantedBy. Can you please explain? |
Introduce a section
[Install]
in unit files, to allowWantedBy
in the section to be able to enable the dependent units.This PR is just a rebased version of #1523, except for minor changes to fix build errors.
Resolves #1382
Supersedes #1523
/cc @kayrus