sdjournal: adds a follow with fields #151
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this allows users to pull data from journal entries that aren't MESSAGE
|
again- could probably wrap |
| if err != nil || len(s) == 0 { | ||
| break fields | ||
| } | ||
| s = s[:len(s)] |
There was a problem hiding this comment.
Thanks for reviewing.
The EnumerateData call allows us to walk over all the different fields in the journal file. Now that I think about it, this can likely be done with multiple calls to GetData as well. Which would likely make it more efficient
There was a problem hiding this comment.
Actually in retrospect, i think this method should be called FollowWithAllFields because many people end up using custom fields in their journal entries. This allows the user to have the option to filter or not.
I think the best way of doing so would be taking out the fields map[string]struct{} parameter to the function
|
closing in favor of #152 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this allows users to pull data from journal entries that aren't "MESSAGE"
would love to hear comments on this