Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support userdata on QEMU PPC64 #666

Open
bgilbert opened this issue Nov 27, 2018 · 15 comments
Open

Support userdata on QEMU PPC64 #666

bgilbert opened this issue Nov 27, 2018 · 15 comments

Comments

@bgilbert
Copy link
Contributor

Feature Request

Environment

QEMU ppc64

Desired Feature

Support reading an Ignition config from userdata. fw_cfg is not supported on ppc64.

Other Information

SMBIOS OEM strings are also not supported; see #656 (comment).

@bgilbert
Copy link
Contributor Author

bgilbert commented Jan 9, 2019

Ideally QEMU and libvirt would gain support for a generic userdata mechanism that works on all CPU architectures; see #656 (comment).

@jcajka
Copy link
Contributor

jcajka commented Feb 20, 2019

Could we in the mean time drop the hard requirement on the qemu_fw_cfg as it break the coreos assembler on platforms that are not supported by it. And from my understanding it is not only way how to interact with ignition, right?

@dustymabe
Copy link
Member

dustymabe commented Feb 20, 2019

Could we in the mean time drop the hard requirement on the qemu_fw_cfg as it break the coreos assembler on platforms that are not supported by it.

What specific error are you seeing?

And from my understanding it is not only way how to interact with ignition, right?

It is on the qemu (local qemu/libvirt) platform.

I didn't realize you had said only way

@jcajka
Copy link
Contributor

jcajka commented Feb 20, 2019

@dustymabe respective kernel module doesn't exists on those platforms so dracut during initramfs always errorout
To clarify my drop has been directed in direction of dropping the requirement on not supported arches(this could be done even on spec file level).

@dustymabe
Copy link
Member

could you try to provide ignition.config.url=http://example.com/ignition.ign on the kernel command line and see if it still errors out?

@jcajka
Copy link
Contributor

jcajka commented Feb 20, 2019

It is at build time of artifacts.

@ajeddeloh
Copy link
Contributor

Ignition itself doesn't require it for building, only at runtime. I'm guessing this is erroring out when rpm-ostree runs dracut and tries to install the kernel module to the initramfs?

@jcajka
Copy link
Contributor

jcajka commented Feb 20, 2019

@ajeddeloh yes, that is the case

@jcajka
Copy link
Contributor

jcajka commented Feb 20, 2019

Do you prefer some change to this repo or just "per package" patch in the spec?

@dustymabe
Copy link
Member

right I was thinking it was probably ignition-dracut.. so we would make the change there:

https://github.com/coreos/ignition-dracut/blob/master/dracut/30ignition/module-setup.sh#L78

Can we do arch specific things in dracut modules ?

@ajeddeloh
Copy link
Contributor

There's not a lot to change in this repo other than adding the ability to exclude platforms from the build process. I'm fine with building Ignition with qemu support that doesn't work on some arches short term. But long term we need to fix it or have a way to disable platforms at compile time. I suppose we could have a patch applied to the spec file that removes qemu support on unsupported platforms, but that seems hacky; it'd be better to make the ignition build process more modular.

The changes would probably need to be made around here: https://github.com/coreos/ignition-dracut/blob/master/dracut/30ignition/module-setup.sh#L78 but I'm not sure what the normal approach for specifying different behavior with different arches for dracut is.

@dustymabe
Copy link
Member

dustymabe commented Feb 20, 2019

i guess dracut is just bash scripts so can probably just uname -i and act differently based on that.

@jcajka
Copy link
Contributor

jcajka commented Feb 20, 2019

@ajeddeloh tbh me neither. I will dig in to the possibility to do it "cleanly" in dracut, otherwise IMHO some ifarch patch will be good for the mean time.

@jlebon
Copy link
Member

jlebon commented Feb 26, 2020

@jaypoulz @Prashanth684 Has a channel for PPC64 been investigated and discussed?

@Prashanth684
Copy link
Contributor

@jaypoulz @Prashanth684 Has a channel for PPC64 been investigated and discussed?

No. it has been a more urgent requirement for s390x, becauseOpenshft libvirt IPI was the only way possible for running the CI. For ppc64, we have the Openstack platform for running the CI, so in terms of priority it has taken a backseat.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants