This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
KVM: add a dash in kernel LOCALVERSION #3489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch should change `uname -r` from `4.8.6rkt-v1` to `4.8.6-rkt-v1`. The missing dash was breaking some scripts to parse the kernel release. Arguably, those scripts were buggy and need to be fixed, but usually CONFIG_LOCALVERSION starts with a "-" (at least on Fedora and Arch).
|
lgtm |
lucab
approved these changes
Dec 19, 2016
Merged
alban
referenced
this pull request
in kinvolk/gobpf
Jan 10, 2017
Signed-off-by: Michael Schubert <michael@kinvolk.io>
alban
referenced
this pull request
in kinvolk/gobpf
Jan 10, 2017
Signed-off-by: Michael Schubert <michael@kinvolk.io>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch should change
uname -rfrom4.8.6rkt-v1to4.8.6-rkt-v1.The missing dash was breaking some scripts to parse the kernel release. Arguably, those scripts were buggy and need to be fixed, but usually CONFIG_LOCALVERSION starts with a "-" (at least on Fedora and Arch).
@iaguis @grahamwhaley @jodh-intel this patch comes from #3487 but this time in a standalone PR as requested.