Skip to content
This repository has been archived by the owner on Feb 24, 2020. It is now read-only.

pkg/pod: avoid nil panic for missing pods #3514

Merged
merged 1 commit into from
Jan 6, 2017
Merged

pkg/pod: avoid nil panic for missing pods #3514

merged 1 commit into from
Jan 6, 2017

Conversation

euank
Copy link
Member

@euank euank commented Jan 6, 2017

If getPod was called for a pod that no longer existed, a panic could
occur when trying to lock it.

This regression was introduced in #3404

Fixes #3513

@euank
pkg/pod: avoid nil panic for missing pods
f29ca09 
If `getPod` was called for a pod that no longer existed, a panic could
occur when trying to lock it.

This regression was introduced in rkt#3404

Fixes rkt#3513
lucab
lucab approved these changes Jan 6, 2017
View reviewed changes
Copy link
Member

@lucab lucab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix, LGTM.

@lucab lucab added this to the v1.23.0 milestone Jan 6, 2017
@lucab lucab merged commit e654bcc into rkt:master Jan 6, 2017
@euank euank deleted the npe-pod branch January 10, 2017 07:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lucab lucab lucab approved these changes

Assignees
No one assigned
Labels
kind/regression reviewed/lgtm
Projects
None yet
Milestone
v1.23.0
Development

Successfully merging this pull request may close these issues.
2 participants
@euank @lucab