This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
stage1/fly: clear FD_CLOEXEC only once #3521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stage1-fly was previously toggling `FD_CLOEXEC` on `RKT_LOCK_FD` multiple times: 1. setting it at first 2. clearing it before exec() 3. setting it again after exec() This commit just clears it once, as exec() is the very last stage1 step and we either exit-fail or never return after that.
|
LGTM. Looks like we use the same wrapper around |
|
The story for other stage1 is a bit more complex and traces back to #628. In short, there may be other fork/exec involved for which we need /cc @jonboulle |
|
@lucab maybe just file a follow up for that one? |
|
After a second pass, the other stage1s look fine as they are. I think I just misread one of the original comments, which left me wondering. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stage1-fly was previously toggling
FD_CLOEXEConRKT_LOCK_FDmultipletimes:
This commit just clears it once, as exec() is the very last stage1 step
and we either exit-fail or never return after that.