Skip to content
This repository has been archived by the owner on Feb 24, 2020. It is now read-only.

stage1: fix incorrect splitting function #3541

Merged
merged 1 commit into from
Jan 19, 2017

Conversation

squeed
Copy link
Contributor

@squeed squeed commented Jan 18, 2017

My previous PR used the wrong splitting function 🙇

Copy link
Contributor

@s-urbaniak s-urbaniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I am worried that we didn't catch this with a functional test. Do you mind to create a follow-up issue, or, even better, add a test here ;-)

@squeed
Copy link
Contributor Author

squeed commented Jan 18, 2017

A good question.
The reason we didn't catch this with a functional test is that the function I refactored swallowed all errors "because best effort," so I emulated that.

Probably this function should output some debugging information we can match on.

@s-urbaniak s-urbaniak added this to the v1.23.0 milestone Jan 19, 2017
@lucab lucab merged commit 8f2332f into rkt:master Jan 19, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants