This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
image gc: don't remove images that currently running pods were made from #3549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the behavior of `rkt image gc` to pass over any images from which currently running pods were created from, regardless of how long ago the image was last used.
|
One thing I didn't do here is change any of the language around "last used", which I can do if we think it would be better rephrased. |
|
On the renaming side, what about the proposed "last started"? But i agree it can be deferred, and as it may also touch into JSON output perhaps better to do it after #3551? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the behavior of
rkt image gcto pass over anyimages from which currently running pods were created from, regardless
of how long ago the image was last used.
Fixes #3385