Skip to content
This repository has been archived by the owner on Feb 24, 2020. It is now read-only.

travis: remove "gimme.local" script #3556

Merged
merged 1 commit into from
Jan 27, 2017
Merged

travis: remove "gimme.local" script #3556

merged 1 commit into from
Jan 27, 2017

Conversation

ybubnov
Copy link
Contributor

@ybubnov ybubnov commented Jan 24, 2017

This patch removes a "gimme.local" script used within the Travis CI
in order to install the correct version of the Go compiler for aarch64
architecture as the version for Travis was broken.

An issue was fixed in the Travis CI itself, therefore the copy of
"gimme.local" is no longer required within rkt source tree. Updated
the configuration of Travis CI accordingly.

Fixes #3555

@ghost
Copy link

ghost commented Jan 24, 2017

Can one of the admins verify this patch?

@s-urbaniak
Copy link
Contributor

ok to test

@ybubnov
Copy link
Contributor Author

ybubnov commented Jan 24, 2017

Despite the version of gimme is 1.0.0, it installs Go amd64 compiler.
An output from the arm64 job https://travis-ci.org/coreos/rkt/jobs/194940626:

$ export TARGET=arm64
...
$ gimme version
v1.0.0
$ go version
go version go1.5.4 linux/amd64

The patch indeed in the updated version of gimme: travis-ci/gimme@v0.2.4...v1.0.0

@ybubnov
Copy link
Contributor Author

ybubnov commented Jan 24, 2017

Oh, it's my mistake, it should export an appropriate environment variable as well:

-  - TARGET=amd64
-  - TARGET=arm64
+  - TARGET=amd64 GIMME_ARCH=amd64
+  - TARGET=arm64 GIMME_ARCH=arm64

@ybubnov
Copy link
Contributor Author

ybubnov commented Jan 25, 2017

Finally make things work.

@ybubnov
Copy link
Contributor Author

ybubnov commented Jan 25, 2017

Both Jenkins jobs failed on TestAppUserGroup test, which is unlikely caused by my changes.

@lucab
Copy link
Member

lucab commented Jan 25, 2017

Jenkins failures are the usual flakes. Semaphore for some reason didn't pick it up. Do you mind re-pushing?

This patch removes a "gimme.local" script used within the Travis CI
in order to install the correct version of the Go compiler for aarch64
architecture as the version for Travis was broken.

An issue was fixed in the Travis CI itself, therefore the copy of
"gimme.local" is no longer required within rkt source tree. Updated
the configuration of Travis CI accordingly.
Copy link
Contributor

@s-urbaniak s-urbaniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once green (flakes seem unrelated), thanks! 🎉

@lucab lucab merged commit 3000312 into rkt:master Jan 27, 2017
@ybubnov ybubnov deleted the remove-gimme-local-from-travis-ci branch January 27, 2017 13:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove "gimme.local"
3 participants