This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 882
tests: remove gexpect from TestAppUserGroup #3561
Merged
s-urbaniak
merged 1 commit into
rkt:master
from
lucab:to-upstream/test-usergroup-no-gexpect
Jan 26, 2017
Merged
tests: remove gexpect from TestAppUserGroup #3561
s-urbaniak
merged 1 commit into
rkt:master
from
lucab:to-upstream/test-usergroup-no-gexpect
Jan 26, 2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TestAppUserGroup currently uses gexpect but does not need any interactivity. This commit switches it away to use golang process spawning and regexp matching.
This still doesn't improve wrt. #3477 flake, I've still seen local failures. |
@s-urbaniak assigning to you for review. |
s-urbaniak
approved these changes
Jan 26, 2017
There is another timeout:
|
oh, sorry, my bad. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestAppUserGroup currently uses gexpect but does not need any
interactivity. This commit switches it away to use golang process
spawning and regexp matching.
Fixes #3560