This repository has been archived by the owner on Feb 24, 2020. It is now read-only.
stage1/kvm: Change RAM calculation, and increase minimum #3572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lucab PTAL |
If you have some central place for this kind of things in ClearContainers, that would be a good place for the umbrella issue. |
|
Semaphore is currently under maintenance, so this will have to wait a bit for the CI to pick it up. |
|
@grahamwhaley this one as well needs to be re-pushed :( |
grahamwhaley
force-pushed
the
20170130_kvm_min_ram
branch
from
407f81b to
4ff935f
Compare
|
Hi @lucab I rebased and pushed, but it looks like semaphore has gone wrong again - I'll try re-pushing again, and if that fails then I'll look harder at it. |
The current values and algorithm for working out the VM memory mean that, for cases such as empty pods, we could end up with as little as 128Mi of RAM. This is too little, and can impact some startup functions (init/systemd) as the kernel sets some resources (such as max-threads) according to how much memory the system has. Improve the situation by setting a minimum RAM size we need, and adjusting the calculations accordingly. Modify the relevant unit tests to match, and extend slightly. Other potential more dynamic solutions (hotplug memory, ballooning solutions etc. ) are much more complex, and will be investigated for the future. Signed-off-by: Graham Whaley <graham.whaley@intel.com>
grahamwhaley
force-pushed
the
20170130_kvm_min_ram
branch
from
4ff935f to
30146a2
Compare
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the memory allocation calculation for kvm.
And bump up the minimum.
I'm going to say:
Fixes: #3382
And if we need then lets open a new ticket to cover any future more dynamic solutions.
Signed-off-by: Graham Whaley graham.whaley@intel.com