Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

design: clarify when it is correct to report steady #239

Open
lucab opened this issue Mar 2, 2020 · 1 comment
Open

design: clarify when it is correct to report steady #239

lucab opened this issue Mar 2, 2020 · 1 comment
Labels
area/updates kind/groundwork needs/more-information

Comments

@lucab
Copy link
Contributor

lucab commented Mar 2, 2020 •
edited

Followup from #233 (comment).

For context, the fleet_lock requires us to:

  • lock a semaphore slot before finalizing/rebooting (/pre-reboot)
  • unlock the semaphore slot after reboot (/report-steady)

In #233, @jlebon had some concerns that we are currently reporting steady quite early, i.e. as soon as the agent is properly initialized. His suggestion was to defer this action a bit more, and wait for a successful Cincinnati check too.
@lucab lucab mentioned this issue Mar 2, 2020
Merged
@lucab
Copy link
Contributor Author

lucab commented Mar 3, 2020

One more thing that I realized when drawing #240.

When updates.enabled = false the agent skips straight from StartState to EndState. That means that any fleet_lock configuration is effectively ignored and /report-stedy is never hit. Is this behavior correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/updates kind/groundwork needs/more-information
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lucab