Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Zincati when booting a live image #63

Closed
bgilbert opened this issue Jul 6, 2019 · 4 comments
Closed

Disable Zincati when booting a live image #63

bgilbert opened this issue Jul 6, 2019 · 4 comments

Comments

@bgilbert
Copy link
Contributor

bgilbert commented Jul 6, 2019

It won't work on PXE or ISO anyway.

I think the most direct approach would be to make zincati.service ConditionKernelCommandLine=! the kargs for PXE and ISO booting. Do we want to do that upstream, or should the distro add a drop-in?

@lucab
Copy link
Contributor

lucab commented Jul 8, 2019

Zincati is already very much specific to Fedora-CoreOS. It also already depends specifically on Ignition platform ID:

static CMDLINE_PLATFORM_FLAG: &str = "ignition.platform.id";

Both options would be fine, but I guess that adding the condition here will make it will simpler to read and reason about for our users.

@bgilbert
Copy link
Contributor Author

bgilbert commented Jul 8, 2019

Unlike on Container Linux, the Ignition platform ID will not encode PXE and ISO boot. There will be separate kargs for that.

@lucab
Copy link
Contributor

lucab commented Jul 8, 2019

Ah, true. Scratch the bits on Ignition platform then. Let's still keep those conditions here, once we settle on the new kargs.

@lucab
Copy link
Contributor

lucab commented Sep 9, 2019

Closed by #126.

@lucab lucab closed this as completed Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants