From ee49c6229917b6e860e25c55e0d69de0b0d6251b Mon Sep 17 00:00:00 2001 From: Dominik Pfaffenbauer Date: Sat, 23 Feb 2019 15:44:33 +0100 Subject: [PATCH] [Order] fix code-generator length --- .../Order/Generator/CartPriceRuleVoucherCodeGenerator.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/CoreShop/Component/Order/Generator/CartPriceRuleVoucherCodeGenerator.php b/src/CoreShop/Component/Order/Generator/CartPriceRuleVoucherCodeGenerator.php index be2f18a051..87b08172dd 100644 --- a/src/CoreShop/Component/Order/Generator/CartPriceRuleVoucherCodeGenerator.php +++ b/src/CoreShop/Component/Order/Generator/CartPriceRuleVoucherCodeGenerator.php @@ -102,7 +102,7 @@ protected static function generateCode($letters, $length) $i = 0; $code = ''; - while ($i <= $length) { + while ($i < $length) { $num = rand() % 33; $tmp = substr($letters, $num, 1); $code = $code . $tmp;