Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 2.2 not working with custom DataObjectLinkGenerator #1383

Closed
D37R4C7 opened this issue May 6, 2020 · 0 comments
Closed

Version 2.2 not working with custom DataObjectLinkGenerator #1383

D37R4C7 opened this issue May 6, 2020 · 0 comments
Assignees
@dpfaffenbauer
Labels
bug
Milestone
2.2.1

Comments

@D37R4C7
Copy link
Contributor

D37R4C7 commented May 6, 2020

Q A
Bug report? yes
Feature request? no
BC Break report? no
RFC? no

#1367 not working with custom DataObjectLinkGenerator, because $params e.g. route is not provided to generate method.

CoreShop/src/CoreShop/Bundle/FrontendBundle/Controller/ProductController.php

Line 61 in b11dd20

$urlToBe = $this->get(LinkGeneratorInterface::class)->generate($product);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dpfaffenbauer dpfaffenbauer

Labels
bug
Projects
None yet
Milestone
2.2.1
Development

No branches or pull requests
2 participants
@D37R4C7 @dpfaffenbauer