Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset Id on __clone #1501

Closed
solverat opened this issue Oct 16, 2020 · 0 comments
Closed

Reset Id on __clone #1501

solverat opened this issue Oct 16, 2020 · 0 comments
Assignees
@dpfaffenbauer
Labels
bug
Milestone
2.2.7

Comments

@solverat
Copy link
Contributor

Q A
Bug report? yes
Feature request? no
BC Break report? no
RFC? no

Based on this commit:

3056d80#diff-c1fac1168445c931571434f970a3ce74c76c0a79d5f253ec4db426bb5951622a

The id reset has been reverted, but is still missing in those two classes:

  • CoreShop\Component\Product\Model\ProductUnitDefinition (complete __clone method missing)
  • CoreShop\Component\Rule\Model\Condition(complete __clone method missing)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dpfaffenbauer dpfaffenbauer

Labels
bug
Projects
None yet
Milestone
2.2.7
Development

No branches or pull requests
2 participants
@solverat @dpfaffenbauer