Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NotificationRulePass detects a addtional empty tag #1532

Closed
albertmueller opened this issue Nov 24, 2020 · 3 comments
Closed

NotificationRulePass detects a addtional empty tag #1532

albertmueller opened this issue Nov 24, 2020 · 3 comments

Comments

@albertmueller
Copy link
Contributor

Q A
Bug report? yes/no
Feature request? no
BC Break report? no
RFC? yes/no

CoreShop dev-master / Pimcore 6.8.4 / PHP 7.4

I found an strage behaviour as i added a custom notification rule:
image

After adding i got this issue:
image

A look on AbstractNotificationRulePass shows me a additional empty tag:
image

Maybe a possible quick fix:

foreach ($container->findTaggedServiceIds($this->tag) as $id => $attributes) {
            foreach ($attributes as $tag) {
                if (!$tag) {
                    continue;
                }
@dpfaffenbauer
Copy link
Member

pretty sure autoloading is activated where you also manually specify the tag?

@albertmueller
Copy link
Contributor Author

albertmueller commented Nov 24, 2020

yes, the other custom rules in shipping and cart works well.

@dpfaffenbauer
Copy link
Member

should be done already

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants