Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 5d and 6d broadcast/reduce/permute/select impls in devices #285

Closed
coreylowman opened this issue Nov 2, 2022 · 3 comments · Fixed by #304
Closed

Add 5d and 6d broadcast/reduce/permute/select impls in devices #285

coreylowman opened this issue Nov 2, 2022 · 3 comments · Fixed by #304

Comments

@coreylowman
Copy link
Owner

To support 5d and 6d tensors from #283 (comment)
@M1ngXU
Copy link
Contributor

M1ngXU commented Nov 2, 2022

i'll do that with #284

@M1ngXU
Copy link
Contributor

M1ngXU commented Nov 2, 2022

should we feature gate 6d tensors? there are LOTS of permutations for 6d tensors

@coreylowman
Copy link
Owner Author

Hah yeah this is the cost of compile time shapes I guess 😀 Is the main concern about testing? I know for other dims we have tests for all possibilities, but we probably don't need to test all for 5d/6d considering the macros work for the rest of the dims

@coreylowman coreylowman mentioned this issue Dec 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Devices/Dyn dimensions refactor coreylowman/dfdx
2 participants
@coreylowman @M1ngXU