Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce test sizes #898

Closed
swfsql opened this issue Dec 5, 2023 · 1 comment
Closed

Reduce test sizes #898

swfsql opened this issue Dec 5, 2023 · 1 comment

Comments

@swfsql
Copy link
Contributor

swfsql commented Dec 5, 2023

The tests already are reasonably small and are fast to run eg. even on the CPU. But when simulating the execution through miri, various tests take more than half an hour, with one in transformers taking one hour. So one possibility to make this easier is to reduce the test sizes to their minimum, as long as they reach their testing goal.

Another benefit for a miri pass when reducing the tests is their memory requirements, as this tends to increase the longer the test needs to run, reaching 2GB of ram per test on the longest ones. So reducing their memory peak should make it easier to run more tests in parallel.

There are 367 tests, with many taking 10~20 seconds. So just focusing on what takes more than a few minutes could already be sufficient for the purpose of running all tests.

This was referenced Dec 5, 2023
@swfsql
Copy link
Contributor Author

swfsql commented Mar 1, 2024

Closing as I think the tests that got run on the linked pr indicated a robust behavior.
But feel free to ping or re-open in case anyone has an interest!

@swfsql swfsql closed this as completed Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant