Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SortableSpec canDrag not used #360

Closed
elongberg opened this issue May 31, 2019 · 4 comments
Closed

SortableSpec canDrag not used #360

elongberg opened this issue May 31, 2019 · 4 comments
Labels

Comments

@elongberg
Copy link

In using the sortable package, I notice the canDrag function of SortableSpec appears to do nothing (it never gets called when actually trying it out in a <skyhook-sortable-list>, and after looking at the package code I believe it's not actually being used).

Is there another method that should be used for this functionality (i.e. being able to specify if a given item in a list can be dragged or not), or is this just an oversight?

@cormacrelf
Copy link
Owner

It’s an oversight. This code should clearly implement canDrag. Thanks for reporting.

this.source = this.dnd.dragSource<DraggedItem<Data>>(null, {

@cormacrelf cormacrelf added bug and removed triage labels May 31, 2019
@zebrada
Copy link

zebrada commented Jun 8, 2019

Did not see this bug report until now but I was just having the same problem.

Happy to see that it is tracked already.

Is there a workaround ? It appears to me that DragSourceSpec can't be modified once it has been created.

@cormacrelf
Copy link
Owner

If there were a workaround I would have mentioned it. Just be patient and I will get to it.

@zebrada
Copy link

zebrada commented Jun 9, 2019

It wasn't my intention to rush you in any way.

Thank you for your commitment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants