Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please use scoped enums throughout Lpf2HubConst.h #49

Open
StefansProjects opened this issue Dec 25, 2020 · 1 comment
Open

Please use scoped enums throughout Lpf2HubConst.h #49

StefansProjects opened this issue Dec 25, 2020 · 1 comment

Comments

@StefansProjects
Copy link

Perhaps you could use scoped enums throughout Lpf2HubConst.h. Especially the Color enum (values) colides with other similar definitions and scoped enums would help to keep the code interoperable with other libraries.
@corneliusmunz
Copy link
Owner

Hi @StefansProjects Thanks for reporting that issue. I have done it for other enums but i have missed that in the "breaking" change from 0.x.x to 1.0.0 Now if i will change it it will be another breaking change. But i will do it if the next "big" change will occur

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@corneliusmunz @StefansProjects