Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search bar query bug #287

Closed
wants to merge 3 commits into from
Closed

Search bar query bug #287

wants to merge 3 commits into from

Conversation

jesshan700
Copy link
Contributor

Fixed search bar query bug

This pull request is the first step towards fixing the search bar query bux

  • fixed the search bar so that every time the user switched to a different page, the search bar is cleared.

Test Plan

1) After searching "main" from the homepage
Screen Shot 2023-05-05 at 1 37 26 PM

2) Search results for bar - search bar is cleared
Screen Shot 2023-05-05 at 2 44 25 PM

3) Search new from the home screen - search bar is cleared
Screen Shot 2023-05-05 at 2 45 11 PM

Screen Shot 2023-05-05 at 2 45 18 PM

4) Switching to FAQ - search bar is cleared - before fix search query was saved in search bar
Screen Shot 2023-05-05 at 2 45 55 PM

Notes

Breaking Changes

  • Database schema change (anything that changes Firestore collection structure)
  • Other change that could cause problems (Detailed in notes)

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jesshan700 jesshan700 temporarily deployed to staging May 5, 2023 18:47 — with GitHub Actions Inactive
@dti-github-bot
Copy link
Member

[diff-counting] Significant lines: 2.

@github-actions
Copy link

github-actions bot commented May 5, 2023

Visit the preview URL for this PR (updated for commit 1ec721e):

https://cu-apts-staging--pr287-jh2228-search-bar-qu-e22hnen7.web.app

(expires Fri, 12 May 2023 18:49:38 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 096ac87b789b31770a01964fe0aaa92d563b9353

Copy link
Contributor

@cyrus14 cyrus14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Jessica! Great job on this UI change this fixes the bug where the search bar was outlined. Looking at the code changes, the setQuery('') for both the events where the down arrow is pressed and enter is pressed is important to match the intuition of the user. All in all, great job on this PR and it is good to have it in the product!

Copy link
Contributor

@AnkitLakkapragada AnkitLakkapragada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work Jessica! This is an important fix and bugs are always important to find and squash. Looking forward to seeing more!

Copy link
Collaborator

@thuypham03 thuypham03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fixing looks great. However, the bug of search bar not reset after switching between different pages still stay, please update this PR with all bugs related to this issue fixed before merge!

@ggsawatyanon
Copy link
Contributor

This PR looks great. However, apart from Sophia's review that the bug remains when switching pages, I also noticed that the search bar is cleared after the down arrow key is pressed, which may not be something the user wants. Also because the search query doesn't actually go through when the down key is pressed so it just clears it without searching anything. Still, good progress though!

@thuypham03
Copy link
Collaborator

Fixed in #302

@thuypham03 thuypham03 closed this Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants