Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental TypeScript Migration #158

Merged
merged 46 commits into from
Mar 10, 2019
Merged

Experimental TypeScript Migration #158

merged 46 commits into from
Mar 10, 2019

Conversation

SamChou19815
Copy link
Contributor

@SamChou19815 SamChou19815 commented Mar 9, 2019

This is a branch that explores how our codebase can be migrated to TypeScript to boost developer productivity.

Rationale

TypeScript has these advantages over Flow:

  • More usage: already over 50% according to 2018 state of JavaScript.
  • Better IDE support (remember MS invented both TS and VSCode)
  • Better community support
  • Better third-party type definitions
  • More clear roadmap than Flow

TypeScript has these disadvantages:

According to my investigation when I'm working these branch, the disadvantages can be easily overcome to trade for a much better IDE support. Autocompletion was much faster than that of flow. The code migration was mostly some syntax change, and adding a few type annotations to avoid 'implicit any'.

Merging Comment

Approve the change only if most of us agree it's good. Also consider merging other changes first before merging this.

Infrastructure Change

  • setup ESLint with typescript support
  • remove old Flow packages
  • migrate the codebase to TS
  • fix all new linter errors
  • setup basic structure for error recovery

Branch Merging Status

  • merge in Michael's changes
  • merge in Megan's changes

Other Bug Fixes

@SamChou19815 SamChou19815 changed the title Experimental ts support [WIP] Experimental TypeScript Migration Mar 9, 2019
@SamChou19815 SamChou19815 added the frontend Frontend Related label Mar 10, 2019
@SamChou19815 SamChou19815 changed the title [WIP] Experimental TypeScript Migration Experimental TypeScript Migration Mar 10, 2019
@mt-xing mt-xing merged commit 7da2cc2 into master Mar 10, 2019
@mt-xing mt-xing deleted the experimental-ts-support branch March 10, 2019 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Frontend Related
Projects
None yet
2 participants