-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental TypeScript Migration #158
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamChou19815
changed the title
Experimental ts support
[WIP] Experimental TypeScript Migration
Mar 9, 2019
SamChou19815
changed the title
[WIP] Experimental TypeScript Migration
Experimental TypeScript Migration
Mar 10, 2019
mt-xing
approved these changes
Mar 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a branch that explores how our codebase can be migrated to TypeScript to boost developer productivity.
Rationale
TypeScript has these advantages over Flow:
TypeScript has these disadvantages:
According to my investigation when I'm working these branch, the disadvantages can be easily overcome to trade for a much better IDE support. Autocompletion was much faster than that of flow. The code migration was mostly some syntax change, and adding a few type annotations to avoid 'implicit any'.
Merging Comment
Approve the change only if most of us agree it's good. Also consider merging other changes first before merging this.
Infrastructure Change
Branch Merging Status
Other Bug Fixes