Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to change prometheus scrape annotations #21

Open
grzesuav opened this issue Jun 28, 2024 · 1 comment
Open

Allow to change prometheus scrape annotations #21

grzesuav opened this issue Jun 28, 2024 · 1 comment

Comments

@grzesuav
Copy link
Contributor

In our setup we have different prometheuses, one special for coroot and one for the whole cluster.

I have coroot promehteus targeting specific coroot pods - node agents and ksm - however due to presence of prometheus.io/scrape: 'true' it is also scraped by global fleet, which is undesired.

Currently this annotation is hardcoded, my proposal is to move it to values.podAnnotations - it still be a default, however people coud change it if needed

@grzesuav
Copy link
Contributor Author

@def implemented this in #28 in backward compatible manner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant