Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate & remove Heap Ballast #5283

Closed
friedrichg opened this issue Apr 24, 2023 · 2 comments · Fixed by #5816
Closed

Deprecate & remove Heap Ballast #5283

friedrichg opened this issue Apr 24, 2023 · 2 comments · Fixed by #5816
Labels
keepalive Skipped by stale bot type/chore Something that needs to be done; not a bug or a feature
Milestone
Release 1.17

Comments

@friedrichg
Copy link
Member

Is your feature request related to a problem? Please describe.
Deprecate and later remove the heap ballast introduced in #1489

Describe the solution you'd like
Since 1.19 we can use GOMEMLIMIT with GOGC which is a better approach at the problem
See https://tip.golang.org/doc/gc-guide

Describe alternatives you've considered
Keeping the option is not ideal, as it has a bad usage of the memory
@friedrichg friedrichg added the type/chore Something that needs to be done; not a bug or a feature label Apr 24, 2023
@friedrichg friedrichg changed the title Deprecate Heap Ballast Deprecate & remove Heap Ballast Apr 24, 2023
@alvinlin123 alvinlin123 added this to the Release 1.16 milestone May 12, 2023
@stale
Copy link

stale bot commented Sep 17, 2023

This issue has been automatically marked as stale because it has not had any activity in the past 60 days. It will be closed in 15 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 17, 2023
@friedrichg friedrichg added the keepalive Skipped by stale bot label Sep 17, 2023
@stale stale bot removed the stale label Sep 17, 2023
@yeya24
Copy link
Contributor

yeya24 commented Nov 9, 2023 •
edited
Loading

Let's move this to release 1.17. Unfortunately we couldn't make it for 1.16

@yeya24 yeya24 modified the milestones: Release 1.16, Release 1.17 Nov 9, 2023
@yeya24 yeya24 mentioned this issue Mar 17, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
keepalive Skipped by stale bot type/chore Something that needs to be done; not a bug or a feature
Projects
None yet
Milestone
Release 1.17
Development

Successfully merging a pull request may close this issue.

Mark mem ballast flag as deprecated yeya24/cortex
3 participants
@alvinlin123 @friedrichg @yeya24