Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discarded queries metric in QFE #5355

Closed
yeya24 opened this issue May 22, 2023 · 0 comments · Fixed by #5356
Closed

Discarded queries metric in QFE #5355

yeya24 opened this issue May 22, 2023 · 0 comments · Fixed by #5356

Comments

@yeya24
Copy link
Contributor

yeya24 commented May 22, 2023

Is your feature request related to a problem? Please describe.
We don't have a good metric to track user query throttling.
Right now, we can look at metrics for the corresponding status code like 422 and 429. But 422 status code doesn't tell which the query was throttled by which limit.

Describe the solution you'd like
We already have some metrics for ingestion about throttling https://github.com/cortexproject/cortex/blob/master/pkg/util/validation/validate.go#L72. A counter metric with label user and reason.

We can have the same for query metric as well in query frontend.
Query frontend can parse limit error message and convert those errors into metric labels.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant