Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.16.0 Store Gateway Query stats - ability to disable #5721

Closed
philiptrovato opened this issue Jan 2, 2024 · 2 comments · Fixed by #5749
Closed

1.16.0 Store Gateway Query stats - ability to disable #5721

philiptrovato opened this issue Jan 2, 2024 · 2 comments · Fixed by #5749

Comments

@philiptrovato
Copy link

Describe the bug
New Store Gateway Query stats are pretty cool, but verbose and generate an excessive amounts of logs. No current flags to disable from what I can tell, must be turned off by setting log level to "warn".

Querier: Log query stats when querying store gateway. #5376

To Reproduce
Steps to reproduce the behavior:

  1. Run Cortex v1.16.0 at info log level
  2. Perform query or ruler operations which hit the SGW

Expected behavior
Expected the new SGW query stats to follow the flag "query_stats_enabled"
Or have its own flag to disable.
Or have the new SGW query stats set at debug level instead of info.

@yeya24
Copy link
Contributor

yeya24 commented Jan 7, 2024

That's a good call.
query_stats_enabled is a flag used in QFE only. I prefer to add a new flag for store gateway stats log.

@yeya24
Copy link
Contributor

yeya24 commented Jan 28, 2024

Sorry for the lag. I just opened a pr to fix this problem. #5749

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants