Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add distributor global limit for ingester client requests #6358

Closed
anna-tran opened this issue Nov 21, 2024 · 0 comments · Fixed by #6376 or #6387
Closed

Add distributor global limit for ingester client requests #6358

anna-tran opened this issue Nov 21, 2024 · 0 comments · Fixed by #6376 or #6387

Comments

@anna-tran
Copy link
Contributor

anna-tran commented Nov 21, 2024

Is your feature request related to a problem? Please describe.
The ingester_client_inflight_push_requests metric measures the number of requests a distributor client is sending to a single ingester, but this is a per-ingester local limit that does not measure how many total inflight requests a distributor is waiting on callback for. This limit can help buildup of inflight requests when there is more than 1 bad ingester that is not responding and causes distributor to hold onto the request.

Describe the solution you'd like
My proposal is to introduce a global limit on the number of inflight requests for distributor (among all the ingester clients) and increment that metric in send.

Describe alternatives you've considered
The cortex_distributor_inflight_push_requests measures the number of Push requests but those are API calls rather than the actual number of requests waiting on callback from ingester (which could be larger).

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant