Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
I'm working on the TSDB blocks compactor for Cortex, for which we need to upgrade the Thanos dependency to the
master
version, in order to be able to enable vertical compaction in Thanos bucket compactor for which I've added an option flag in this PR thanos-io/thanos#1917.Thanos recently did a round of "all dependencies upgrade" and this Thanos update also brings several Cortex dependencies updated, including Prometheus.
I patiently went through the change set and overall looks good to me. I've added some notes below about changes we should be aware of.
Which issue(s) this PR fixes:
No issue
Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]
Significative changes
Upgrade Thanos to the
master
version. Changes should be safe for our experimental TSDB storage.Prometheus version bump, including the labels pkg refactoring done by Tom.
According to the release notes there should be no breaking changes.
According to the changelog and diff all changes affect features we don't use.
Bigtable and storage packages have been moved to their own modules. Looking at the diff and the changelog both changes look safe.
Small changes
The changes look safe.
The changelog just mention few fixes and updated generated code.
The changes look safe.
The changelog mentions minor fixes.
Minor fixes to
kiB
parsing.Added
NewPrometheusPushSink
which we don't use.Upgraded from
v13.0.2
tov13.3.0
. Looking at the changelog few new features and fixes have been added. The diff also looks small and safe.According to the changelog and the diff, few minor changes have been done other than adding support for the S3
us-east-1
regional endpoint.According to the release notes a max depth of 10K has been added.
According to the release notes and diff they've just improved error handling.
According to the changelog and diff the only change impacting us is using xxhash for the registered metrics.
Significative indirect changes
Version bump in the K8S client, which we don't directly use.