Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded Thanos dependency #1935

Merged
merged 3 commits into from
Jan 7, 2020

Conversation

pracucci
Copy link
Contributor

What this PR does:

I'm working on the TSDB blocks compactor for Cortex, for which we need to upgrade the Thanos dependency to the master version, in order to be able to enable vertical compaction in Thanos bucket compactor for which I've added an option flag in this PR thanos-io/thanos#1917.

Thanos recently did a round of "all dependencies upgrade" and this Thanos update also brings several Cortex dependencies updated, including Prometheus.

I patiently went through the change set and overall looks good to me. I've added some notes below about changes we should be aware of.

Which issue(s) this PR fixes:
No issue

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Significative changes

-       github.com/thanos-io/thanos v0.8.1
+       github.com/thanos-io/thanos v0.8.1-0.20191223135439-39f8623b577f

Upgrade Thanos to the master version. Changes should be safe for our experimental TSDB storage.

-       github.com/prometheus/prometheus v1.8.2-0.20190918104050-8744afdd1ea0
+       github.com/prometheus/prometheus v1.8.2-0.20191126064551-80ba03c67da1

Prometheus version bump, including the labels pkg refactoring done by Tom.

-       github.com/gogo/protobuf v1.2.2-0.20190730201129-28a6bbf47e48
+       github.com/gogo/protobuf v1.3.1

According to the release notes there should be no breaking changes.

-       github.com/hashicorp/consul/api v1.1.0
+       github.com/hashicorp/consul/api v1.3.0

According to the changelog and diff all changes affect features we don't use.

-       cloud.google.com/go v0.44.1
+       cloud.google.com/go/bigtable v1.1.0
+       cloud.google.com/go/storage v1.3.0

Bigtable and storage packages have been moved to their own modules. Looking at the diff and the changelog both changes look safe.

Small changes

-       gopkg.in/yaml.v2 v2.2.2
+       gopkg.in/yaml.v2 v2.2.5

The changes look safe.

-       google.golang.org/api v0.11.0
+       google.golang.org/api v0.14.0

The changelog just mention few fixes and updated generated code.

-       golang.org/x/net v0.0.0-20190923162816-aa69164e4478
+       golang.org/x/net v0.0.0-20191112182307-2180aed22343

The changes look safe.

-       github.com/uber/jaeger-client-go v2.20.0+incompatible
+       github.com/uber/jaeger-client-go v2.20.1+incompatible

The changelog mentions minor fixes.

-       github.com/alecthomas/units v0.0.0-20190717042225-c3de453c63f4
+       github.com/alecthomas/units v0.0.0-20190924025748-f65c72e2690d

Minor fixes to kiB parsing.

-       github.com/armon/go-metrics v0.0.0-20190430140413-ec5e00d3c878
+       github.com/armon/go-metrics v0.3.0

Added NewPrometheusPushSink which we don't use.

-       github.com/Azure/go-autorest/autorest v0.9.2 // indirect
-       github.com/Azure/go-autorest/autorest/adal v0.8.0 // indirect
-       github.com/Azure/go-autorest/autorest/to v0.3.0 // indirect
-       github.com/Azure/go-autorest/autorest/validation v0.2.0 // indirect

Upgraded from v13.0.2 to v13.3.0. Looking at the changelog few new features and fixes have been added. The diff also looks small and safe.

-       github.com/aws/aws-sdk-go v1.25.22
+       github.com/aws/aws-sdk-go v1.25.35

According to the changelog and the diff, few minor changes have been done other than adding support for the S3 us-east-1 regional endpoint.

-       github.com/json-iterator/go v1.1.7
+       github.com/json-iterator/go v1.1.8

According to the release notes a max depth of 10K has been added.

-       github.com/hashicorp/memberlist v0.1.4
+       github.com/hashicorp/memberlist v0.1.5

According to the release notes and diff they've just improved error handling.

-       github.com/prometheus/client_golang v1.1.0
+       github.com/prometheus/client_golang v1.2.1

According to the changelog and diff the only change impacting us is using xxhash for the registered metrics.

Significative indirect changes

+k8s.io/api v0.0.0-20191115095533-47f6de673b26
+k8s.io/apimachinery v0.0.0-20191115015347-3c7067801da2
+k8s.io/klog v1.0.0
+k8s.io/kube-openapi
+k8s.io/utils

Version bump in the K8S client, which we don't directly use.

Signed-off-by: Marco Pracucci <marco@pracucci.com>
Signed-off-by: Marco Pracucci <marco@pracucci.com>
@pracucci pracucci mentioned this pull request Dec 31, 2019
3 tasks
Signed-off-by: Marco Pracucci <marco@pracucci.com>
Copy link
Contributor

@jtlisi jtlisi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants