-
Notifications
You must be signed in to change notification settings - Fork 804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TSDB: Expose shipper metrics via ingester #1983
TSDB: Expose shipper metrics via ingester #1983
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, good job @pstibrany ! I left a couple of comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job. LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM nice work!
Since we have one TSDB shipper per tenant in memory, we need to gather all of these metrics and sum them together (fortunately they are all counters). One shipper metric, thanos_shipper_upload_compacted_done ("If 1 it means shipper uploaded all compacted blocks from the filesystem.") was skipped and is not exposed, as there is no good way to group it across all tenants. Ingester metrics were moved to separate file, metrics.go. shipper metrics have their own type and are only used from TSDB code. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with a nit.
@gouthamve May you also take a look, please?
This should never happen. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
That was very cleverly done! |
Since we have one TSDB shipper per tenant in memory, we need to gather all of these metrics and sum them together (fortunately they are all counters).
One shipper metric,
thanos_shipper_upload_compacted_done
("If 1 it means shipper uploaded all compacted blocks from the filesystem.") was skipped and is not exposed, as there is no good way to group it across all tenants.All shipper metrics now have
cortex_ingester
prefix instead of originalthanos
prefix.Checklist
CHANGELOG.md
updated - the order of entries should be[CHANGE]
,[FEATURE]
,[ENHANCEMENT]
,[BUGFIX]