Don't prefix Thanos index-cache metrics #2627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(with name="index-cache", and appropriate component) Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
khaines
approved these changes
May 25, 2020
pracucci
reviewed
May 27, 2020
3 tasks
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
pracucci
reviewed
Jun 1, 2020
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
simonswine
pushed a commit
to grafana/e2e
that referenced
this pull request
Jan 13, 2022
* Removed Cortex-specific metrics for index cache, reuse Thanos metrics (with name="index-cache", and appropriate component) Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Don't prefix metrics, but use new label instead. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Fix tests. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Fixed tests after renaming metrics. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Add cortex_ prefix to metrics (re-)defined in Cortex Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Fix integration tests. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Fix comment. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Fix component name. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com> * Added PR number to CHANGELOG.md entries. Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does: This PR modifies metrics names used by index cache to be consistent with Thanos and other caches (chunks, metadata).
This change also changes some other metrics that used
cortex_querier_andcortex_storegateway_prefix, as documented by changelog.Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]