Remove -store.fullsize-chunks option #2656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pracucci
reviewed
May 29, 2020
| @@ -15,15 +15,13 @@ type Config struct{} | |||
|
|
|||
| var ( | |||
| // DefaultEncoding exported for use in unit tests elsewhere | |||
| DefaultEncoding = Bigchunk | |||
| alwaysMarshalFullsizeChunks = true | |||
There was a problem hiding this comment.
Why are you saying it was unused? Being the default true doesn't it mean it's always used unless explicitly disabled via CLI flag?
There was a problem hiding this comment.
Yes, it was written this way to avoid changing things for existing users.
I mean the option to disable was never used.
There was a problem hiding this comment.
However I got the change wrong.
There was a problem hiding this comment.
Yes, then we need to remove the flag while always keeping it enabled ;)
bboreham
force-pushed
the
remove-fullsize-flag
branch
from
c23ce13 to
4a00949
Compare
pracucci
approved these changes
May 29, 2020
CHANGELOG.md
Outdated
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| * [CHANGE] Query Frontend now uses Round Robin to choose a tenant queue to service next. #2553 | |||
| * [CHANGE] `-promql.lookback-delta` is now deprecated and has been replaced by `-querier.lookback-delta` along with `lookback_delta` entry under `querier` in the config file. `-promql.lookback-delta` will be removed in v1.4.0. #2604 | |||
| * [CHANGE] Removed `-store.fullsize-chunks` option which was undocumented and unused (it broke ingester hand-overs). | |||
There was a problem hiding this comment.
Would you mind adding the PR number at the end of the line? The release script we use look for PRs missing in the CHANGELOG (for manual check) and does the check based on the PR number here.
gouthamve
approved these changes
Jun 3, 2020
bboreham
force-pushed
the
remove-fullsize-flag
branch
from
f1f926b to
856112c
Compare
It broke ingester hand-overs, and is not needed now we use BigChunk. I left in the code which allows non-full-size chunks to be read in: maybe someone has some in a database. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
bboreham
force-pushed
the
remove-fullsize-flag
branch
from
856112c to
77f5a1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It broke ingester hand-overs, and is not needed now we use BigChunk.
Fixes #1163
Checklist
CHANGELOG.mdupdated