Distributor limits #4071
Merged
Distributor limits #4071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
pstibrany
force-pushed
the
distributor-limits
branch
from
181a6dd to
d9e543f
Compare
stevesg
approved these changes
Apr 12, 2021
Co-authored-by: Steve Simpson <steve.simpson@grafana.com> Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
pstibrany
force-pushed
the
distributor-limits
branch
from
125b3d3 to
c664a5c
Compare
pracucci
reviewed
Apr 12, 2021
There was a problem hiding this comment.
Good job @pstibrany and thanks for working on distributor limits! I left few comments, overall LGTM!
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
|
Thank you for reviews! I've addressed your feedback, please take a look again. |
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
pracucci
approved these changes
Apr 14, 2021
Signed-off-by: Peter Štibraný <peter.stibrany@grafana.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does: This PR introduces two new limits for distributor: max ingestion rate (samples/sec) that distributor can accept, and max number of inflight requests. When these limits are reached, distributor returns error which is translated into 5xx.
In addition to limits, new metrics are introduced. These expose current values as well as limits.
This PR builts on top of #4070, and will be rebased after #4070 is merged.Done.Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]