Make AM grpc MaxRecvMsgSize and MaxSendMsgSize configurable #5338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emanlodovice
force-pushed
the
expose-am-grpc-size-to-config
branch
2 times, most recently
from
7d41c9e to
47cc774
Compare
emanlodovice
force-pushed
the
expose-am-grpc-size-to-config
branch
2 times, most recently
from
38003b5 to
52b07c6
Compare
alvinlin123
reviewed
May 10, 2023
CHANGELOG.md
Outdated
| @@ -13,6 +13,7 @@ | |||
| * [BUGFIX] Ruler: Validate if rule group can be safely converted back to rule group yaml from protobuf message #5265 | |||
| * [BUGFIX] Querier: Convert gRPC `ResourceExhausted` status code from store gateway to 422 limit error. #5286 | |||
| * [BUGFIX] Alertmanager: Route web-ui requests to the alertmanager distributor when sharding is enabled. #5293 | |||
| * [FEATURE] Added 2 flags `-alertmanager.alertmanager-client.grpc-max-send-msg-size` and ` -alertmanager.alertmanager-client.grpc-max-recv-msg-size` to configure alert manager grpc client message size limits. #5338 | |||
There was a problem hiding this comment.
Kindly move this to line 9, close to the other [FEATURE] :)
There was a problem hiding this comment.
Updated, thanks for checking 🙇
emanlodovice
force-pushed
the
expose-am-grpc-size-to-config
branch
from
52b07c6 to
8a7cbb3
Compare
|
@emanlodovice Let's fix changelog first otherwise CI won't run. |
emanlodovice
force-pushed
the
expose-am-grpc-size-to-config
branch
2 times, most recently
from
3f06cd3 to
487d3b7
Compare
Signed-off-by: Emmanuel Lodovice <lodovice@amazon.com>
emanlodovice
force-pushed
the
expose-am-grpc-size-to-config
branch
from
487d3b7 to
9ef7748
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Make Alert manager grpc
MaxRecvMsgSizeandMaxSendMsgSizeconfigurable.Which issue(s) this PR fixes:
Fixes #5330
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]