Handling CMK AccessDenied errors #5420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
alanprot
changed the title
alanprot
force-pushed
the
kmsfix2
branch
3 times, most recently
from
4919be5 to
ac123e8
Compare
Signed-off-by: Alan Protasio <alanprot@gmail.com>
alanprot
force-pushed
the
kmsfix2
branch
3 times, most recently
from
4a3fead to
9233777
Compare
Signed-off-by: Alan Protasio <alanprot@gmail.com>
Signed-off-by: Alan Protasio <alanprot@gmail.com>
Signed-off-by: Alan Protasio <alanprot@gmail.com>
alvinlin123
approved these changes
Jul 3, 2023
Signed-off-by: Alan Protasio <alanprot@gmail.com>
alanprot
force-pushed
the
kmsfix2
branch
4 times, most recently
from
6a4eaf9 to
a92fa14
Compare
alvinlin123
approved these changes
Jul 3, 2023
Signed-off-by: Alan Protasio <alanprot@gmail.com>
2 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Handling CMK AccessDenied errors.
This will not fix all CMK related errors when the key is revoked so probably some other follow up PR will be needed to handle other edge cases.
Fixes:
This also update thanos objstore to bring thanos-io/objstore#59
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]