Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Experimental] Signing write requests #5430

Merged
merged 5 commits into from
Jun 30, 2023

Conversation

alanprot
Copy link
Member

What this PR does:
Sign the write requests to prevent future data corruption as #5419

Which issue(s) this PR fixes:
Related to: #5419

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

@alanprot alanprot force-pushed the sign-write-req branch 4 times, most recently from d6dc79e to d2971e0 Compare June 27, 2023 22:57
@alanprot alanprot marked this pull request as ready for review June 27, 2023 23:58
@alanprot alanprot requested a review from alvinlin123 June 28, 2023 04:43
pkg/util/grpcclient/grpcclient.go Outdated Show resolved Hide resolved
pkg/util/grpcclient/signing_handler.go Show resolved Hide resolved
pkg/util/grpcclient/signing_handler.go Show resolved Hide resolved
pkg/util/grpcclient/signing_handler_test.go Show resolved Hide resolved
alanprot added 4 commits June 29, 2023 09:45
Signed-off-by: Alan Protasio <alanprot@gmail.com>
Signed-off-by: Alan Protasio <alanprot@gmail.com>
Signed-off-by: Alan Protasio <alanprot@gmail.com>
Signed-off-by: Alan Protasio <alanprot@gmail.com>
@alanprot alanprot force-pushed the sign-write-req branch 3 times, most recently from dc0c2c2 to 570d2cc Compare June 29, 2023 18:36
Signed-off-by: Alan Protasio <alanprot@gmail.com>
@yeya24 yeya24 merged commit c83a26d into cortexproject:master Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants