Making GCInterval Configurable #5550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krishnateja325
force-pushed
the
GCConfig
branch
3 times, most recently
from
7b3fde6 to
1d362f4
Compare
yeya24
requested changes
Sep 6, 2023
pkg/alertmanager/multitenant.go
Outdated
| @@ -119,7 +120,7 @@ func (cfg *MultitenantAlertmanagerConfig) RegisterFlags(f *flag.FlagSet) { | |||
|
|
|||
| f.BoolVar(&cfg.EnableAPI, "experimental.alertmanager.enable-api", false, "Enable the experimental alertmanager config api.") | |||
| f.IntVar(&cfg.APIConcurrency, "alertmanager.api-concurrency", 0, "Maximum number of concurrent GET API requests before returning an error.") | |||
|
|
|||
| f.DurationVar(&cfg.GCInterval, "alertmanager.gc-interval", 30*time.Minute, "Garbage collection Interval") | |||
There was a problem hiding this comment.
The flag and the configuration name is kind of confusing. Can we make the name and flag description more informative like alertmanager.alerts-gc-interval
There was a problem hiding this comment.
sure, I will modify it.
Signed-off-by: Krishna Teja Puttagunta <krishnateja325@gmail.com>
krishnateja325
force-pushed
the
GCConfig
branch
from
1d362f4 to
bd5dfa2
Compare
yeya24
approved these changes
Sep 6, 2023
alvinlin123
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
-alertmanager.alerts-gc-intervalto configure alert manager Garbage collection Interval.Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]