Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade objstore and change Azure bucket client #5645

Merged
merged 3 commits into from
Nov 15, 2023

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Nov 12, 2023

What this PR does:

Upgraded objstore package and allow the SDK to support authenticate via Azure Workload Identity.
Added connection_string config to authenticate via Azure SAS token.
Mark msi_resource as deprecated and will be removed in the future.

Which issue(s) this PR fixes:
Fixes #5353

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Ben Ye <benye@amazon.com>
Signed-off-by: Ben Ye <benye@amazon.com>
Signed-off-by: Ben Ye <benye@amazon.com>
@yeya24 yeya24 closed this Nov 14, 2023
@yeya24 yeya24 reopened this Nov 14, 2023
@pull-request-size pull-request-size bot added size/L and removed size/M labels Nov 14, 2023
@yeya24 yeya24 merged commit 470027e into cortexproject:master Nov 15, 2023
27 checks passed
@yeya24 yeya24 deleted the update-objstore branch November 15, 2023 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using azure workload identity requires using a deprecated side car injection
2 participants