Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix distributor sends native histograms #5679

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Nov 27, 2023

What this PR does:

Allow distributor to actually include native histograms data in write request when sending to ingesters.
This should make the new metric added in #5289 actually work.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Ben Ye <benye@amazon.com>
Copy link
Member

@alanprot alanprot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! :)

@alanprot alanprot merged commit 84b982c into cortexproject:master Nov 27, 2023
14 checks passed
@yeya24 yeya24 deleted the fix-histogram-distributor branch November 27, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants