Count the number of rate-limited samples in distributor_samples_in_total #5714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danielblando @wenxu1024 Can you guys help review this pr? |
|
Hi @damnever, for your usecase, do you need to differentiate how many samples are It is probably fine to add those samples to be counted in I am unsure why current implementation doesn't count those rate limited samples though |
|
LGTM |
|
@yeya24 |
Signed-off-by: Xiaochao Dong (@damnever) <the.xcdong@gmail.com>
damnever
force-pushed
the
received-samples
branch
from
36a42dc to
703519d
Compare
Signed-off-by: Xiaochao Dong (@damnever) <the.xcdong@gmail.com>
damnever
force-pushed
the
received-samples
branch
from
703519d to
f2b43dc
Compare
yeya24
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Currently, there are no metrics that include rate-limited samples. I am considering counting the number of rate-limited samples in distributor_samples_in_total. Alternatively, we could add a separate metric.
Which issue(s) this PR fixes:
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]