Time check in query priority now considers overall data select time window (including range selectors, modifiers and lookback delta) #5758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinjung04
changed the title
Signed-off-by: Justin Jung <jungjust@amazon.com>
Signed-off-by: Justin Jung <jungjust@amazon.com>
justinjung04
force-pushed
the
query-priority
branch
from
8a5699a to
f47fc78
Compare
Signed-off-by: Justin Jung <jungjust@amazon.com>
yeya24
reviewed
Jan 31, 2024
justinjung04
changed the title
justinjung04
changed the title
Signed-off-by: Justin Jung <jungjust@amazon.com>
Signed-off-by: Justin Jung <jungjust@amazon.com>
yeya24
reviewed
Feb 2, 2024
Signed-off-by: Justin Jung <jungjust@amazon.com>
Signed-off-by: Justin Jung <jungjust@amazon.com>
justinjung04
changed the title
Signed-off-by: Justin Jung <jungjust@amazon.com>
justinjung04
changed the title
Signed-off-by: Justin Jung <jungjust@amazon.com>
justinjung04
force-pushed
the
query-priority
branch
from
5690fdb to
887f111
Compare
Signed-off-by: Justin Jung <jungjust@amazon.com>
yeya24
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Improves time bound check for query priority, such that the range of subquery is also evaluated.
Also, added
data_fetch_min_timeanddata_fetch_max_timein query stats to help with query priority configuration.For example,
ts=2024-02-05T22:08:44.07399Z caller=handler.go:372 level=info org_id=fake msg="query stats" component=query-frontend method=POST path=/prometheus/api/v1/query_range response_time=3.655097ms query_wall_time_seconds=0.002303539 fetched_series_count=1 fetched_chunks_count=1 fetched_samples_count=6 fetched_chunks_bytes=38 fetched_data_bytes=212 split_queries=1 status_code=200 response_size=357 data_select_max_time=1707170910 data_select_min_time=1707163710 query_length=2 user_agent=Grafana/9.4.3 priority=2 param_start=1707167310 param_step=15 param_end=1707170910 param_query=upWhich issue(s) this PR fixes:
n/a
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]