Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing how ring ownership is calculated on the ring status page #5889

Merged
merged 4 commits into from
Apr 25, 2024
Merged

Fixing how ring ownership is calculated on the ring status page #5889

merged 4 commits into from
Apr 25, 2024

Conversation

alanprot
Copy link
Member

@alanprot alanprot commented Apr 25, 2024 •
edited
Loading

What this PR does:

This PR include 3 changes:

  • Fix how the ring owership is calculated on the ring status page
    • Before we were calculating the distance from the token to the next one, but instead, we should calculate the distance from the previous one.
    • If AZ aware is enabled, only take tokens from the ingester AZ to calculate the ownership
    • Add a column to show the difference in percentual from the expected ownership to the actual ownership.
      Screenshot 2024-04-24 at 5 26 33 PM

Which issue(s) this PR fixes:
Fixes #

Checklist

  • [NA] Tests updated
  • [NA] Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

yeya24
yeya24 approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@alanprot alanprot enabled auto-merge (squash) April 25, 2024 00:38
@alanprot
Fixing how ring ownership is calculated on the ring status page
fc1bf54 
Signed-off-by: alanprot <alanprot@gmail.com>
@yeya24
Copy link
Contributor

yeya24 commented Apr 25, 2024

Test failure is related

@yeya24
Copy link
Contributor

yeya24 commented Apr 25, 2024

I don't see changelog has been added. Should we mention the new column added?

alanprot added 2 commits April 24, 2024 21:08
@alanprot
Fix test
9995767 
Signed-off-by: alanprot <alanprot@gmail.com>
@alanprot
Changelog
462439d 
Signed-off-by: alanprot <alanprot@gmail.com>
@alanprot
Copy link
Member Author

I don't see changelog has been added. Should we mention the new column added?

Done :D

@alanprot
fix test
778a6d3 
Signed-off-by: alanprot <alanprot@gmail.com>
@alanprot alanprot merged commit cf574c9 into cortexproject:master Apr 25, 2024
16 checks passed
@alanprot alanprot mentioned this pull request May 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yeya24 yeya24 yeya24 approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alanprot @yeya24