Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backfilling the new limits when updating the metrics #5955

Merged
merged 2 commits into from
May 16, 2024

Conversation

alanprot
Copy link
Member

What this PR does:
Follow up of #5950

This PR is adding some missing things:

  • Changelog
  • Add the per_labelset_series_limit dimention on the cortex_discarded_samples_total metric
  • Backfill the new limits when Updating the cortex_ingester_active_series_per_labelset
    • Before this change, a new metric "matching" the new limits needed to be added so we could backfill it.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • [NA] Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: alanprot <alanprot@gmail.com>
Signed-off-by: alanprot <alanprot@gmail.com>
@alanprot alanprot enabled auto-merge (squash) May 16, 2024 21:52
@alanprot alanprot merged commit 6be4779 into cortexproject:master May 16, 2024
16 checks passed
@alanprot alanprot deleted the per-labelset-limit-2 branch May 16, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants