Remove query_store_for_labels_enabled configuration
#5984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@harry671003 can you help review this one? |
alanprot
force-pushed
the
deprecating/query_store_for_labels_enabled
branch
from
e32205a to
ac89360
Compare
Signed-off-by: alanprot <alanprot@gmail.com>
alanprot
force-pushed
the
deprecating/query_store_for_labels_enabled
branch
from
ac89360 to
86e4d57
Compare
…rom ingsters Signed-off-by: alanprot <alanprot@gmail.com>
alanprot
force-pushed
the
deprecating/query_store_for_labels_enabled
branch
from
71b6a12 to
c93092b
Compare
alanprot
changed the title
query_store_for_labels_enabled configurationquery_store_for_labels_enabled configuration
harry671003
reviewed
May 28, 2024
| @@ -103,14 +102,15 @@ func (cfg *Config) RegisterFlags(f *flag.FlagSet) { | |||
| flagext.DeprecatedFlag(f, "querier.iterators", "Deprecated: Use iterators to execute query. This flag is no longer functional; Batch iterator is always enabled instead.", util_log.Logger) | |||
| //lint:ignore faillint Need to pass the global logger like this for warning on deprecated methods | |||
| flagext.DeprecatedFlag(f, "querier.batch-iterators", "Deprecated: Use batch iterators to execute query. This flag is no longer functional; Batch iterator is always enabled now.", util_log.Logger) | |||
| //lint:ignore faillint Need to pass the global logger like this for warning on deprecated methods | |||
| flagext.DeprecatedFlag(f, "querier.query-store-for-labels-enabled", "Deprecated: Querying long-term store is always enabled.", util_log.Logger) | |||
There was a problem hiding this comment.
Yeah .. thi give a warning if the flag is still present on the cli.., make sense ?
There was a problem hiding this comment.
Shouldn't we set this flag when we start to deprecate the flag? I think the title is a bit of misleading...
Remove query_store_for_labels_enabled configuration we are actually deprecating the config here. Not removing.
Removing means to remove the flag entirely and it should throw error if specified
friedrichg
approved these changes
May 29, 2024
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This configuration is deprecated for a long time.
This PR is removing this config from the codebase:
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]