Add matchers filtering field to rules api #6083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euniceek
force-pushed
the
matches-filtering-field
branch
3 times, most recently
from
c9c3a9f to
67b5f14
Compare
|
Thanks! |
alanprot
approved these changes
Jul 12, 2024
yeya24
reviewed
Jul 12, 2024
Signed-off-by: Eunice Kim <kimeuni@amazon.com>
euniceek
force-pushed
the
matches-filtering-field
branch
2 times, most recently
from
60505f3 to
6182163
Compare
Signed-off-by: Eunice Kim <kimeuni@amazon.com>
euniceek
force-pushed
the
matches-filtering-field
branch
from
6182163 to
6b0709e
Compare
yeya24
reviewed
Jul 15, 2024
Signed-off-by: Eunice Kim <kimeuni@amazon.com>
yeya24
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR adds support for label matchers as URL query params to the
rulesAPI. It filters both recording and alerting rules via their labels.Prometheus recently merged in a change to support this functionality: prometheus/prometheus#10194
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]