Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Author and user configuration #95

Open
6 tasks
coryodaniel opened this issue Jun 9, 2020 · 0 comments
Open
6 tasks

Author and user configuration #95

coryodaniel opened this issue Jun 9, 2020 · 0 comments
Assignees
Milestone

Comments

@coryodaniel
Copy link
Owner

coryodaniel commented Jun 9, 2020

This will probably be more of an epic. This is a stream of conciousness

  • All operator-user configuration should be accessible via environment variables
    • BONNY_POD_NAMESPACE
    • BONNY_POD_SERVICE_ACCOUNT
    • Bonny.Config.labels
    • Bonny.Config.cluster_name
  • Devise a consistent naming pattern for configuration to separate operator author from operator user. eg group name is an author config, pod namespace is a user config
  • A few env vars are set that are metadata for the cluster, delineate those. (BONNY_POD_NAME, BONNY_POD_IP)
  • BONNY_POD_NAMESPACE is confusing, its controls the namespace bonny watches
  • "BONNY" shouldn't be something an end-user of an operator should be concerned with, support an env var prefix for each operator
  • Split Bonny.Config into ~Bonny.Config.EndUser and ~Bonny.Config.Author (names are hard)

Splitting may be as simple as all author config is compile time config, so do it via config/prod.exs and all user config is runtime, so use env vars.

@coryodaniel coryodaniel added this to the 1.0 release milestone Jun 9, 2020
@coryodaniel coryodaniel self-assigned this Jun 9, 2020
@mruoss mruoss modified the milestones: 1.0 release, 1.1 Release Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants