Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gas ring model: sun position #10

Open
carmeloevoli opened this issue Mar 26, 2021 · 1 comment
Open

Gas ring model: sun position #10

carmeloevoli opened this issue Mar 26, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@carmeloevoli
Copy link
Member

The gas ring model cannot be used with an observer position different than [8.5,0,0]. An exception should be raised if not.

@carmeloevoli carmeloevoli added the enhancement New feature or request label Mar 26, 2021
@adundovi adundovi self-assigned this Apr 1, 2021
@adundovi
Copy link
Contributor

adundovi commented Apr 7, 2021

This can be solved by introducing checks in the integrators' constructors which accepts the gas ring model. The ring model would provide its requirements (like the observer position) and the integrator would use them to check if everything is O.K. with other settings. But I would leave this change after the release of 1.0 as it is more like a new feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants