Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: AWS IAM Role Service Account #28

Closed
grifx opened this issue Mar 30, 2020 · 3 comments
Closed

Feature Request: AWS IAM Role Service Account #28

grifx opened this issue Mar 30, 2020 · 3 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@grifx
Copy link

grifx commented Mar 30, 2020

Hi @cosmo0920,

First thank you for your contribution by open-sourcing this project.

I wanted to let you know that AWS introduced a new feature called: IAM Roles for Service Accounts

The problem we're facing is similar to: grafana/grafana#21594

AWS SDK has this concept of CredentialProviderChain. We should use the default chain and prepend (if needed) custom providers based on the configuration provided by the user potentially using the factories provided by the sdk. The Chain will try the providers sequentially and return the FIRST working credential. Basically, we shouldn't have to instantiate the TokenFileWebIdentityCredentials. The SDK should automatically do this for us when using the default CredentialProviderChain.
Alternatively, we can do what has been done on grafana by checking if some env vars are set (it's a bit easier, but will require us to test if it works).

Note: We might have to update the aws-sdk.

I'm not a go developer so I can't do much but I hope this helps.

Thank you,

@cosmo0920 cosmo0920 added enhancement New feature or request help wanted Extra attention is needed labels Mar 30, 2020
@cosmo0920
Copy link
Owner

I'm not familiar with the new AWS IAM RolesCredentials.
Patch is welcome.

@groner
Copy link
Contributor

groner commented Mar 30, 2020

I think this was addressed in #24.

@cosmo0920
Copy link
Owner

Yep. This is already added in #24.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants