Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SHA1 implementation from @cosmjs/crypto #1003

Closed
webmaster128 opened this issue Jan 22, 2022 · 0 comments · Fixed by #1010
Closed

Remove SHA1 implementation from @cosmjs/crypto #1003

webmaster128 opened this issue Jan 22, 2022 · 0 comments · Fixed by #1010
Milestone

Comments

@webmaster128
Copy link
Member

webmaster128 commented Jan 22, 2022

The SHA1 implementation in @cosmjs/crypto originates from IOV Core. I don't remember if it was ever used somewhere or if we just built it to show the nice generic HashFunction interface amd Hmac implementation.

I would like to switch to @noble/hashes because it would avoid pulling in all those dependencies written for node.js that make it very hard to work woth Webpack 5. And because it is well maintained and audited. This library does not have SHA1 as it is probably not needed.

As far as I can tell, SHA1 is not used in Cosmos.

@webmaster128 webmaster128 added this to the 0.28.0 milestone Jan 22, 2022
@webmaster128 webmaster128 changed the title Remove sha1 Remove SHA1 implementation from @cosmjs/crypto Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant